From 00e4ef6b7be7f62521caca09defe44cd72e3cab2 Mon Sep 17 00:00:00 2001 From: rixx Date: Sun, 15 Mar 2015 00:54:24 +0100 Subject: imap only shows name if there are unread emails --- py3status/modules/imap.py | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/py3status/modules/imap.py b/py3status/modules/imap.py index d7ce5be..017bb3b 100644 --- a/py3status/modules/imap.py +++ b/py3status/modules/imap.py @@ -26,17 +26,21 @@ class Py3status: mail_count = self._get_mail_count() response = { - 'cached_until': time() + self.cache_timeout, - 'full_text': '{}: {}'.format(self.name, mail_count) + 'cached_until': time() + self.cache_timeout } - new_mail_color = i3s_config['color_good'] - check_failed_color = i3s_config['color_bad'] + new_mail_color = i3s_config['color_bad'] + response['full_text'] = 'blaa' if mail_count == 'N/A': - response['color'] = check_failed_color + response['color'] = '' + response['full_text'] = mail_count elif mail_count != 0: response['color'] = new_mail_color + response['full_text'] = self.name + else: + response['color'] = new_mail_color + response['full_text'] = '' return response -- cgit v1.3 From f65145ea0e39a6764c7de8ceb183e7c6eefe930e Mon Sep 17 00:00:00 2001 From: rixx Date: Sun, 15 Mar 2015 01:57:40 +0100 Subject: unread mail string is now fully configurable (format string) --- py3status/modules/imap.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/py3status/modules/imap.py b/py3status/modules/imap.py index cace8bd..1e01513 100644 --- a/py3status/modules/imap.py +++ b/py3status/modules/imap.py @@ -18,7 +18,7 @@ class Py3status: criterion = 'UNSEEN' imap_server = '' mailbox = 'INBOX' - name = 'Mail' + name = 'Mail: %unseen' password = '' port = '993' user = '' @@ -38,7 +38,7 @@ class Py3status: response['full_text'] = mail_count elif mail_count != 0: response['color'] = new_mail_color - response['full_text'] = self.name + response['full_text'] = self.name.replace('%unseen', str(mail_count)) else: response['color'] = new_mail_color response['full_text'] = '' -- cgit v1.3 From b133eaa38c047827962c2913a3bd7d45f0942a7a Mon Sep 17 00:00:00 2001 From: rixx Date: Sun, 15 Mar 2015 01:59:49 +0100 Subject: Choose to hide the mail status if no unseen mails exist --- py3status/modules/imap.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/py3status/modules/imap.py b/py3status/modules/imap.py index 1e01513..2bb5923 100644 --- a/py3status/modules/imap.py +++ b/py3status/modules/imap.py @@ -16,6 +16,7 @@ class Py3status: # available configuration parameters cache_timeout = 60 criterion = 'UNSEEN' + hide_if_zero = False imap_server = '' mailbox = 'INBOX' name = 'Mail: %unseen' @@ -40,8 +41,11 @@ class Py3status: response['color'] = new_mail_color response['full_text'] = self.name.replace('%unseen', str(mail_count)) else: - response['color'] = new_mail_color - response['full_text'] = '' + response['color'] = '' + if self.hide_if_zero: + response['full_text'] = '' + else: + response['full_text'] = self.name.replace('%unseen', '0') return response -- cgit v1.3 From 2d021f0daf724bc165ec903daa0c456048497a79 Mon Sep 17 00:00:00 2001 From: rixx Date: Tue, 17 Mar 2015 22:34:00 +0100 Subject: format string instead of strange string replace --- py3status/modules/imap.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/py3status/modules/imap.py b/py3status/modules/imap.py index 9b5aa5d..63e8665 100644 --- a/py3status/modules/imap.py +++ b/py3status/modules/imap.py @@ -19,7 +19,7 @@ class Py3status: hide_if_zero = False imap_server = '' mailbox = 'INBOX' - name = 'Mail: %unseen' + name = 'Mail: {unseen}' new_mail_color = '' password = '' port = '993' @@ -40,7 +40,7 @@ class Py3status: response['full_text'] = mail_count elif mail_count != 0: response['color'] = self.new_mail_color - response['full_text'] = self.name.replace('%unseen', str(mail_count)) + response['full_text'] = self.name.format(unseen=mail_count) else: response['color'] = '' if self.hide_if_zero: -- cgit v1.3 From cb0170e3d4ac700211d3e2a69ef3c2556fdbc3b9 Mon Sep 17 00:00:00 2001 From: rixx Date: Tue, 17 Mar 2015 22:41:27 +0100 Subject: this is what insufficient testing gets you --- py3status/modules/imap.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/py3status/modules/imap.py b/py3status/modules/imap.py index 63e8665..757d9fd 100644 --- a/py3status/modules/imap.py +++ b/py3status/modules/imap.py @@ -46,7 +46,7 @@ class Py3status: if self.hide_if_zero: response['full_text'] = '' else: - response['full_text'] = self.name.replace('%unseen', '0') + response['full_text'] = self.name.format(unseen=mail_count) return response -- cgit v1.3